feat: implement model_bool hook for controlling model truthiness #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pl
force-pushed
the
lupl/model-bool-feature
branch
from
01ea313 to
f99052e
Compare
lu-pl
force-pushed
the
lupl/model-bool-feature
branch
from
f99052e to
b9329c9
Compare
lu-pl
force-pushed
the
lupl/model-bool-feature
branch
5 times, most recently
from
1c6fc01 to
41291be
Compare
lu-pl
force-pushed
the
lupl/model-bool-feature
branch
from
41291be to
20f6c2c
Compare
b1rger
approved these changes
Nov 19, 2024
lu-pl
force-pushed
the
lupl/model-bool-feature
branch
from
20f6c2c to
be69e8e
Compare
Model truthiness is an important metric for the rdfproxy grouping mechanism. Currently, a model is considered truthy if at least one of its fields is truthy. This is a sane default, yet certain frontend demands require different model truth conditions. The feature introduces a model_bool option in the model_config that allows client code to specify conditions/predicates for determining model truthiness. Closes #110, closes #112.
The tests cover all cases discussed in #110.
lu-pl
force-pushed
the
lupl/model-bool-feature
branch
from
be69e8e to
ddcb490
Compare
b1rger
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110, closes #112.